Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not serialize CaseSensitiveClaimsIdentity.SecurityToken. #2896

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Do not serialize CaseSensitiveClaimsIdentity.SecurityToken. #2896

merged 3 commits into from
Oct 22, 2024

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented Oct 11, 2024 •
edited
Loading

Fixes #2897

@pmaytak pmaytak requested a review from a team as a code owner October 11, 2024 06:11
brentschmaltz
brentschmaltz approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have some possible breaking changes so we should let users know.
Technically we should bump the major version, but these changes have only been out in 8.1.1 and 8.1.2.

We may want to think about delisting 8.1.1 and 8.1.2 when we release 8.1.3

@brentschmaltz brentschmaltz merged commit f8849c5 into dev Oct 22, 2024
5 checks passed
@pmaytak pmaytak deleted the pmaytak/csci-serializable branch October 31, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbw2 msbw2 msbw2 approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

@brentschmaltz brentschmaltz brentschmaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Don't serialize CaseSensitiveClaimsIdentity.SecurityToken
4 participants
@pmaytak @brentschmaltz @jennyf19 @msbw2