Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #2894

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Fix typo #2894

merged 7 commits into from
Oct 22, 2024

Conversation

westin-m
Copy link
Contributor

Closes #1873

Tested with repro in bug

@westin-m westin-m requested a review from a team as a code owner October 10, 2024 22:42
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19
Copy link
Collaborator

wonder if this needs to be in a major version - thoughts @brentschmaltz ?

@pmaytak
Copy link
Contributor

pmaytak commented Oct 18, 2024

wonder if this needs to be in a major version - thoughts @brentschmaltz ?

Does it work currently at all? Like xsi:Type? If yes, I suppose this could be a breaking change, since folks rely on this behavior.

@westin-m
Copy link
Contributor Author

Does it work currently at all? Like xsi:Type? If yes, I suppose this could be a breaking change, since folks rely on this behavior.

This works because xsi:type is what's expected. It's a runtime change, which I think should be fine to bring in.

@westin-m westin-m merged commit 2858319 into dev Oct 22, 2024
5 checks passed
@westin-m westin-m deleted the westin/SamlTypo branch October 22, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants