Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Tests: NameAndRoleClaimDelegates and RoleClaims #2873

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

kellyyangsong
Copy link
Contributor

See explanation here.

Fixes #2841

@kellyyangsong kellyyangsong requested a review from a team as a code owner October 3, 2024 22:55
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

@jennyf19 jennyf19 added this to the 8.2.0 milestone Oct 4, 2024
pmaytak
pmaytak previously requested changes Oct 4, 2024
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a breaking change.

@kellyyangsong kellyyangsong force-pushed the kellysong/role-claim-flaky branch from f148c64 to 29d4e31 Compare October 22, 2024 22:33
@kellyyangsong
Copy link
Contributor Author

This may be a breaking change.

Fixed!

@jennyf19 jennyf19 requested a review from pmaytak October 22, 2024 22:39
@jennyf19 jennyf19 requested review from pmaytak and removed request for pmaytak October 22, 2024 22:42
@kellyyangsong kellyyangsong dismissed pmaytak’s stale review October 22, 2024 22:46

Addressed Peter's concern + he is not here to re-review (on vacation)

@kellyyangsong kellyyangsong merged commit b5f3756 into dev Oct 22, 2024
5 checks passed
@kellyyangsong kellyyangsong deleted the kellysong/role-claim-flaky branch December 16, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants