Set internal _syncAfter using only AutomaticRefreshInterval.

[brentschmaltz]

The internal _syncAfter field controls if metadata is refreshed (http call).
The value was set to the minimum of AutomaticRefreshInterval and RefreshInterval.

RefreshInterval controls the interval that must pass for RequestRefresh() to make an http call.
RefreshInterval is usually a much smaller timespan, so in effect many more calls would be made to obtain metadata.

This fix only uses the AutomaticRefreshInterval to set _syncAfter.
This has the side effect of extending the time for the next AutomaticRequest, however, that makes sense.

#2866

[pmaytak]

We don't seem to set _configurationRetrieverState to Running anywhere?

[msbw2]

It looks like it is set to running just before this method gets started in a new task. Or does the fact that it's in a new task change the call context?

[kellyyangsong]

On ln 251? It's being set to ConfigurationRetrieverIdle. Regardless, I think we should address it outside of this PR

[msbw2]

Oh, so the arguments are flipped in the call to Interlocked.CompareExchange.

[pmaytak]

Yes, I think so. (The CompareExchange is not super intuitive since it compares the first and third parameters...)

if (Interlocked.CompareExchange(ref _configurationRetrieverState, ConfigurationRetrieverRunning, ConfigurationRetrieverIdle) != ConfigurationRetrieverRunning)
                {
                    _ = Task.Run(UpdateCurrentConfiguration, CancellationToken.None);
                }

Logic:
If the state is idle (is not running),
then set state to running and call the update
If the state is running
then don't do anything.

at the end of Update method, we correctly reset the state to idle

azure-activedirectory-identitymodel-extensions-for-dotnet/src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs

Line 317 in e8e9ecf

Interlocked.Exchange(ref _configurationRetrieverState, ConfigurationRetrieverIdle);