Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove perl dependency #2830

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Remove perl dependency #2830

merged 1 commit into from
Sep 19, 2024

Conversation

keegan-caruso
Copy link
Contributor

Rewrite VerifyResourceUsage in powershell

Remove perl dependency
f3360ee 
Rewrite VerifyResourceUsage in powershell
@keegan-caruso keegan-caruso marked this pull request as ready for review September 18, 2024 17:49
@keegan-caruso keegan-caruso requested a review from a team as a code owner September 18, 2024 17:49
@keegan-caruso
Copy link
Contributor Author

keegan-caruso commented Sep 18, 2024 •
edited
Loading

Link isn't updating: but here is the new Wilson-PR run that is passing on the changed steps: https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1362980&view=results

kllysng
kllysng approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@kllysng kllysng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @keegan-caruso!

jennyf19
jennyf19 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmprieur
Copy link
Contributor

Awesome!

@keegan-caruso keegan-caruso merged commit 5f437df into dev Sep 19, 2024
8 of 9 checks passed
@keegan-caruso keegan-caruso deleted the kecaruso/remove-perl branch September 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kllysng kllysng kllysng approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keegan-caruso @jmprieur @jennyf19 @kllysng