Added sample tests for the new validation path #2801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs
Outdated
Show resolved
Hide resolved
| @@ -4,6 +4,7 @@ | |||
| using System; | |||
| using System.IdentityModel.Tokens.Jwt; | |||
| using System.Security.Claims; | |||
| using System.Threading; | |||
There was a problem hiding this comment.
Why do we need a new assembly?
There was a problem hiding this comment.
CancellationToken requires it.
| /// Tests how the class under test handles a token which is not yet valid | ||
| /// </summary> | ||
| [Fact] | ||
| public void NetYetValidToken_NewPath() |
There was a problem hiding this comment.
This is too fractured.
We need sets of tests using TheoryData for Lifetime, Audience, etc.
Why not part of JsonWebTokenHandler.ValidateLifetimeTests
|
These tests are being removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sample tests for the new validation path
Description
Added sample tests for new validation path and aligned errors returned.
Part of #2711