Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish base for ValidationParameters refactor #2709

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Jul 15, 2024

Establish base for ValidationParameters refactor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

  • Restored original Validators.cs file for all the original validators.
  • Removed duplicate original code from our new Validators.TypeOfValidator classes.
  • Added new ValidationParameters class to be used in the new code branches.

This is an organizational effort to divide the work and avoid conflicts for the next stage of the exception handling and logging stream.

@iNinja iNinja requested a review from a team as a code owner July 15, 2024 17:30
Copy link
Contributor

@FuPingFranco FuPingFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iNinja iNinja merged commit 863ba0f into dev Jul 15, 2024
4 checks passed
@brentschmaltz brentschmaltz deleted the brentsch/ValidationParameters branch July 18, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants