Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Token: Remove Exceptions #2702

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Read Token: Remove Exceptions #2702

merged 5 commits into from
Jul 17, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Jul 11, 2024

Read Token: Remove Exceptions

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

  • Implemented new version of ReadToken removing TokenValidationParameters, dropping the TokenReader delegate, and returning a TokenReadingResult that wraps provides ExceptionDetails without throwing, and saves its logs as MessageDetails.
    Actual creation of the JsonWebToken untouched at this point. Exceptions that are thrown as part of the token creation are wrapped and returned as part of the result.
  • Added nullability annotations on new code.
  • Added tests.

@iNinja iNinja requested a review from a team as a code owner July 11, 2024 13:50
…y the new, refactored version in the new partial.
@iNinja iNinja merged commit a7ef799 into dev Jul 17, 2024
4 checks passed
@iNinja iNinja deleted the iinglese/read-token-result branch November 15, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants