Dispose SignatureProviders after moving to staging cache. #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegoldman2
reviewed
Jul 8, 2024
msbw2
reviewed
Jul 8, 2024
msbw2
reviewed
Jul 8, 2024
brentschmaltz
force-pushed
the
brentsch/AsymmetricDispose
branch
from
cf409fd to
dd91270
Compare
pmaytak
reviewed
Jul 11, 2024
pmaytak
reviewed
Jul 11, 2024
pmaytak
reviewed
Jul 11, 2024
src/Microsoft.IdentityModel.Tokens/InMemoryCryptoProviderCache.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
Jul 11, 2024
pmaytak
reviewed
Jul 12, 2024
pmaytak
reviewed
Jul 19, 2024
GeoK
reviewed
Jul 20, 2024
Move compacted SignatureProviders to new cache to ensure dispose is called. Add delegate to check if signature provider should be removed from cache. Separate expired from compaction Dispose SignatureProvider if it was never cached.
brentschmaltz
force-pushed
the
brentsch/AsymmetricDispose
branch
from
07a4b92 to
5e5a5db
Compare
GeoK
reviewed
Jul 20, 2024
pmaytak
reviewed
Jul 20, 2024
GeoK
approved these changes
Jul 20, 2024
pmaytak
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves a couple of issues.
SignatureProviders are ref counted, but not removed and disposed when the ref count goes to zero. The logic is most likely the SignatureProvider will be used again in a short period.
The significant change is that on compaction SignatureProviders are moved to a 'compactCache'. Periodically, the 'compactCache' is examined for SignatureProviders that can be disposed.
The CryptoProviderFactory will never return a SignatureProvider from the 'compactCache' when asked to create a SignatureProvider.
SignatureProviders that were not cached, will be disposed when released.
It is helpful when reviewing, all tasks are run in serial on a background task.