Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuer signing key validation: Remove exceptions #2672

Merged
merged 7 commits into from
Jun 29, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Jun 27, 2024

Issuer signing key validation: Remove exceptions

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Removed exceptions as part of signing key validation.

Description

  • Implemented new (internal momentarily) method for signing key validation which replaces exception throwing with a return of the new SigningKeyValidationResult containing the exception information.
  • Added new delegate signature for signing key validation
  • Added tests around all the previous cases.

@iNinja iNinja requested a review from a team as a code owner June 27, 2024 20:05
# Conflicts:
#	src/Microsoft.IdentityModel.Tokens/Validation/Validators.IssuerSecurityKey.cs
@iNinja iNinja merged commit 0c5172c into dev Jun 29, 2024
4 checks passed
@iNinja iNinja deleted the validate-issuer-security-key-result branch June 29, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants