Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove net 461 #2642

Merged
merged 4 commits into from
Jun 18, 2024
Merged

remove net 461 #2642

merged 4 commits into from
Jun 18, 2024

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 requested a review from a team as a code owner June 18, 2024 01:42
westin-m
westin-m approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@westin-m westin-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jennyf19

@brentschmaltz brentschmaltz merged commit aad1e25 into dev Jun 18, 2024
4 checks passed
@jennyf19 jennyf19 deleted the jennyf/rmv462 branch June 18, 2024 17:36
@joegoldman2 joegoldman2 mentioned this pull request Jun 23, 2024
Closed
JoshLozensky
JoshLozensky reviewed Jun 27, 2024
View reviewed changes
src/Microsoft.IdentityModel.Tokens/RsaSecurityKey.cs
@@ -76,7 +76,7 @@ public override bool HasPrivateKey
{
// imitate signing
byte[] hash = new byte[20];
#if NET461 || NET462 || NET472 || NETSTANDARD2_0 || NET6_0_OR_GREATER
#if NET462 || NET472 || NETSTANDARD2_0 || NET6_0_OR_GREATER
Copy link
Contributor

@JoshLozensky JoshLozensky Jun 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these all the versions we support? Does this matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLozensky JoshLozensky JoshLozensky left review comments

@westin-m westin-m westin-m approved these changes

@brentschmaltz brentschmaltz brentschmaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jennyf19 @brentschmaltz @JoshLozensky @westin-m