Fix JwtSecurityToken Missing Mapping When Creating a Token. #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 29, 2024 09:34
…ub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet into francofung/FixEncryptionInteropWrapper
added 2 commits
May 1, 2024 14:01
westin-m
reviewed
May 1, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
westin-m
reviewed
May 1, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
May 3, 2024
pmaytak
reviewed
May 3, 2024
src/Microsoft.IdentityModel.Tokens/X509EncryptingCredentials.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
May 3, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
May 3, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
JoshLozensky
requested changes
May 16, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerNonParallelRunTests.cs
Outdated
Show resolved
Hide resolved
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerNonParallelRunTests.cs
Outdated
Show resolved
Hide resolved
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
…dlerNonParallelRunTests.cs Co-authored-by: kellyyangsong <[email protected]>
…dlerTests.WithContextSwitches.cs Co-authored-by: kellyyangsong <[email protected]>
| JsonWebToken jsonToken = tokenHandler.ReadToken(token) as JsonWebToken; | ||
|
|
||
| Assert.NotNull(jsonToken); | ||
| Assert.Equal(jsonToken._alg, SecurityAlgorithms.RsaOaepKeyWrap); |
There was a problem hiding this comment.
Why not use jsonWebToken.Alg?
There was a problem hiding this comment.
The underscore variables should really be private...
There was a problem hiding this comment.
I was curious why were they not private when working on them? I changed it to use 'Alg' same as in JwtSecurityTokenHandler. Thanks Brent & Peter!
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
May 17, 2024
src/Microsoft.IdentityModel.Tokens/X509EncryptingCredentials.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/X509EncryptingCredentials.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
May 17, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
May 17, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Show resolved
Hide resolved
pmaytak
reviewed
May 17, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
May 17, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
JoshLozensky
approved these changes
May 17, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenHandlerTests.WithContextSwitches.cs
Outdated
Show resolved
Hide resolved
pmaytak
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds mapping to Algorithm (alg) so it should be one of the registered at IANA "JSON Web Signature and Encryption Algorithms" (https://www.iana.org/assignments/jose/jose.xhtml) as described on topic 4.1.1 of RFC7516 (https://datatracker.ietf.org/doc/html/rfc7516#page-12).
Fixes #2089