Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional metadata parameters to OpenIdConnectConfiguration #2499

Merged
merged 11 commits into from
Jun 14, 2024
Merged

Add additional metadata parameters to OpenIdConnectConfiguration #2499

merged 11 commits into from
Jun 14, 2024

Conversation

joegoldman2
Copy link
Contributor

Fixes #2498.

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info

@joegoldman2 joegoldman2 requested a review from a team as a code owner April 19, 2024 15:40
@jennyf19 jennyf19 added this to the 7.5.2 milestone May 1, 2024
@halter73 halter73 mentioned this pull request May 31, 2024
Closed
@halter73
Copy link
Contributor

@brentschmaltz Do you think this will make it in soon? It'd be nice if we could use these new APIs in dotnet/aspnetcore#51686.

@brentschmaltz
Copy link
Member

brentschmaltz commented Jun 13, 2024 •
edited
Loading

@joegoldman2 Thanks for the reordering.
Let's handle #2456 separately.

brentschmaltz
brentschmaltz requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see corresponding changes to OpenIdConnectConfigurationSerializer.

@joegoldman2
Copy link
Contributor Author

OpenIdConnectConfigurationSerializer

What do you mean? OpenIdConnectConfigurationSerializer has been updated a well in this PR.

@brentschmaltz
Copy link
Member

@joegoldman2 ahh, the file was collapsed and i missed it.
I am looking it over.

@brentschmaltz
Copy link
Member

@joegoldman2 approved.

@brentschmaltz brentschmaltz merged commit b8b244b into AzureAD:dev Jun 14, 2024
5 checks passed
@joegoldman2 joegoldman2 deleted the additional-metadata-params branch June 14, 2024 03:37
@joegoldman2 joegoldman2 mentioned this pull request Jun 15, 2024
Merged
5 tasks
@josephdecock
Copy link

I think the milestone on this issue should be 7.6.1. It looks like that's when this was actually released?

@pmaytak pmaytak modified the milestones: 7.5.2, 7.6.1 Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentschmaltz brentschmaltz brentschmaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.6.1
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add some missing metadata parameters to OpenIdConnectConfiguration
6 participants
@joegoldman2 @halter73 @brentschmaltz @josephdecock @jennyf19 @pmaytak