Use user-provided values as Utf8 #2492
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmaytak
commented
Feb 21, 2024
src/Microsoft.IdentityModel.Tokens/TokenValidationParameters.cs
Outdated
Show resolved
Hide resolved
pmaytak
commented
Feb 21, 2024
src/Microsoft.IdentityModel.JsonWebTokens/Json/JsonWebToken.PayloadClaimSet.cs
Outdated
Show resolved
Hide resolved
pmaytak
commented
Mar 7, 2024
src/Microsoft.IdentityModel.JsonWebTokens/Json/JsonWebToken.PayloadClaimSet.cs
Show resolved
Hide resolved
pmaytak
commented
Mar 7, 2024
| return _iss; | ||
| } | ||
| } | ||
| public override string Issuer => Encoding.UTF8.GetString(IssuerUtf8.ToArray()); |
There was a problem hiding this comment.
- Encoding.UTF8.GetString with ReadOnlySpan overload is only available on .NET Core 2.1+ (not Net Fx).
- I assume ToArray allocates a new array.
- Since IssuerUtf8 can change, we can't "cache" the string representation, so have to convert it to string each time.
pmaytak
commented
Mar 7, 2024
| SecurityToken securityToken, | ||
| TokenValidationParameters validationParameters, | ||
| BaseConfiguration configuration) | ||
| { | ||
| if (validationParameters == null) | ||
| throw LogHelper.LogArgumentNullException(nameof(validationParameters)); | ||
|
|
||
| string issuer = Encoding.UTF8.GetString(issuerUtf8.ToArray()); |
There was a problem hiding this comment.
We'll still need to convert the Memory to string in places like here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2495
ReadOnlyMemory<byte>property for UTF8 issuer in TokenValidationParameters, JsonWebToken, BaseConfiguration.