Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to breaking change announcement in IDX10506 #2478

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

halter73
Copy link
Contributor

@halter73 halter73 commented Feb 2, 2024

When an IDX10506 exception is thrown from JsonWebTokenHandler there's a good chance this is due to a breaking change to ASP.NET Core 8.

This adds a link to the breaking change announcement at https://learn.microsoft.com/en-us/dotnet/core/compatibility/aspnet-core/8.0/securitytoken-events

A few people have run into this already. See https://stackoverflow.com/questions/77515249/custom-token-validator-not-working-in-net-8 and https://developercommunity.visualstudio.com/t/ASPNET-Core-8:-Delegate-SignatureValida/10525320

@jennyf19

When an IDX10506 exception is thrown from JsonWebTokenHandler, there's a
good chance this is due to a breaking change to ASP.NET Core 8.

This adds a link to the breaking change announcement at
https://learn.microsoft.com/en-us/dotnet/core/compatibility/aspnet-core/8.0/securitytoken-events
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19 jennyf19 added this to the 7.3.1 milestone Feb 3, 2024
@jennyf19 jennyf19 merged commit 39d659e into AzureAD:dev Feb 3, 2024
4 checks passed
@jennyf19
Copy link
Collaborator

jennyf19 commented Feb 3, 2024

included in 7.3.1 release

sruke pushed a commit that referenced this pull request Feb 24, 2024
Update YAML to build previews

Add ReadOnlySpan overloads

Add benchmark

Add ValidateAndGetOutputSize for spans

Remove duplication

Update benchmark

Remove duplicates

Update

Add benchmarks

Update

Replace ReadyOnlySpan with ReadOnlyMemory

Update test

Update benchmark naming

Move ArrayPool to JsonWebToken level

Update CreateHeaderClaimSet

Update benchmark for JWE to resolve error

Fix a typo (#2479)

* update comment for azp in jsonwebtoken

* removed extra words

Link to breaking change announcement in IDX10506 (#2478)

When an IDX10506 exception is thrown from JsonWebTokenHandler, there's a
good chance this is due to a breaking change to ASP.NET Core 8.

This adds a link to the breaking change announcement at
https://learn.microsoft.com/en-us/dotnet/core/compatibility/aspnet-core/8.0/securitytoken-events

7.3.1 changelog (#2476)

* 7.3.1 changelog

* two additions

* add space

fix log message dup (#2481)

Reduce duplication

Fix comment

Set _encodedTokenMemory as readonly

Remove unnecessary private method

Use Base64UrlEncoding.Decode with action

Use ValidateAndGetOutputSize(ReadOnlySpan<char> strSpan..) thoughout

Add tests

Revert change

Temporarily allow publishing to NuGet

use just `1` for preview

up version to 7.4.0 for preview

Separate JWS and JWE benchmarks
sruke pushed a commit that referenced this pull request Feb 24, 2024
Update YAML to build previews

Add ReadOnlySpan overloads

Add benchmark

Add ValidateAndGetOutputSize for spans

Remove duplication

Update benchmark

Remove duplicates

Update

Add benchmarks

Update

Replace ReadyOnlySpan with ReadOnlyMemory

Update test

Update benchmark naming

Move ArrayPool to JsonWebToken level

Update CreateHeaderClaimSet

Update benchmark for JWE to resolve error

Fix a typo (#2479)

* update comment for azp in jsonwebtoken

* removed extra words

Link to breaking change announcement in IDX10506 (#2478)

When an IDX10506 exception is thrown from JsonWebTokenHandler, there's a
good chance this is due to a breaking change to ASP.NET Core 8.

This adds a link to the breaking change announcement at
https://learn.microsoft.com/en-us/dotnet/core/compatibility/aspnet-core/8.0/securitytoken-events

7.3.1 changelog (#2476)

* 7.3.1 changelog

* two additions

* add space

fix log message dup (#2481)

Reduce duplication

Fix comment

Set _encodedTokenMemory as readonly

Remove unnecessary private method

Use Base64UrlEncoding.Decode with action

Use ValidateAndGetOutputSize(ReadOnlySpan<char> strSpan..) thoughout

Add tests

Revert change

Temporarily allow publishing to NuGet

use just `1` for preview

up version to 7.4.0 for preview

Separate JWS and JWE benchmarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants