Add back support for Guid values in JwtPayload... #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @brentschmaltz ... Seems like a difference between Newtonsoft <-> System.Text.Json. I went ahead and added a quirk for this since it seemed trivial, but let me know if this behavior was deliberately changed. In my situation, it'd be a lot easier to make the fix here as opposed to fixing and upgrading the library I'm calling that's adding the claim with the |
|
@KevinH-MS appreciate the added tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back support for Guid values in JwtPayload...
Changes
JsonSerializerPrimitvesto serialize claim values of typeGuidasstring(rather than throwing an Exception)...Description
In versions of
Microsoft.IdentityModel.Tokens< 7.0.0-preview4, claim values could have values of typeGuidand would be serialized successfully. This appears to have been regressed with the rewrite of the serializer implementation.I checked the round-trip behavior with older versions, and it seems that the serialized strings are subsequently deserialized as
string(byJwtPayload.Deserialize), so I left the behavior asymmetric (rather than try-parsing all string values asGuid).Fixes #2439