Optmise IDX10503 #2436
Merged
Optmise IDX10503 #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentschmaltz
requested changes
Jan 5, 2024
jmprieur
approved these changes
Jan 9, 2024
jmprieur
reviewed
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The keys tried during token validation are public keys used to validate the tokens and are listed on a public endpoint. They should be logged without PII to enable partner debugging more easily.
The text of the error should read instead "The token's kid is either missing or doesn't match any of the keys in the configuration" or similar to better reflect the flow as it's possible the token does have a kid, it just doesn't match the keys in config.
WI:
https://identitydivision.visualstudio.com/Engineering/_boards/board/t/Auth%20Client%20-%20AuthNZ%20-%20Customer%20trust/Backlog%20items/?workitem=2723627