Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple benchmark runs from test projects. #2413

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

brentschmaltz
Copy link
Member

@brentschmaltz brentschmaltz commented Nov 22, 2023

Adjusted tests to use the same claims, keys and more realistic settings in runs.
Benchmark tests no longer depend on test projects for defaults as these can change when tests change.

Added simple way to debug through tests to verify settings.

Adjusted tests to use the same claims, keys and more realistic settings in runs.
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brentschmaltz brentschmaltz merged commit 21d2f6d into dev Nov 22, 2023
5 checks passed
@brentschmaltz brentschmaltz deleted the brentsch/Benchmarks branch November 30, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants