Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to 6x behavior with GetPayloadClaim<object>("aud") #2331

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

brentschmaltz
Copy link
Member

@brentschmaltz brentschmaltz commented Sep 26, 2023

In 6x, GetPayloadClaim("aud") will return a single string when aud was a single value.
The changes in 7 resulted in a List with one value, which broke some users.

This change returns to the same behavior as 6x.

Note: GetPayloadClaim("aud") would return a string.

JsonWebToken.Audiences is a better approach to access the 'aud' values as during the deserialization of the JWT, the audience values are deserialized.

Addresses: #2328

Copy link
Contributor

@sruke sruke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brentschmaltz brentschmaltz merged commit cb46565 into dev Sep 27, 2023
4 checks passed
@brentschmaltz brentschmaltz deleted the brentsch/AudienceClaim branch September 27, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants