Introduce maxdepth for reading and writing in JsonSerializerPrimitives #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegan-caruso
requested review from
brentschmaltz,
jmprieur,
jennyf19 and
westin-m
keegan-caruso
commented
Aug 31, 2023
westin-m
reviewed
Aug 31, 2023
src/Microsoft.IdentityModel.Tokens/Json/JsonSerializerPrimitives.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.Tokens.Tests/Json/JsonSerializerPrimitivesTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Json/JsonSerializerPrimitives.cs
Outdated
Show resolved
Hide resolved
westin-m
approved these changes
Aug 31, 2023
brentschmaltz
approved these changes
Aug 31, 2023
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 6, 2023
#2284) * Introduce maxdepth for reading and writing in JsonSerializerPrimitives * fix log message * Add tests for objects with more properties * change method of incrementing depth --------- Co-authored-by: Keegan Caruso <[email protected]>
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 7, 2023
#2284) * Introduce maxdepth for reading and writing in JsonSerializerPrimitives * fix log message * Add tests for objects with more properties * change method of incrementing depth --------- Co-authored-by: Keegan Caruso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2269