Add support for RSA-OAEP 256 (#1293) #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
@brentschmaltz can you review when you have time? #1231 |
trukhanov
reviewed
Sep 22, 2023
test/Microsoft.IdentityModel.KeyVaultExtensions.Tests/KeyVaultKeyWrapProviderTests.cs
Outdated
Show resolved
Hide resolved
|
I removed all the ifdefs since they were effectively "> net45", and no longer needed |
|
@karoberts sorry to get to this so late, but we would like to take this. |
removing obsoleted ifdefs since net452 support was removed
Sounds great! I have rebased on top of latest dev. |
|
@karoberts Awesome, we are trying to get this into IdentityModel 8 that is coordinated with .net 9. |
brentschmaltz
approved these changes
Jun 13, 2024
|
@karoberts Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RSA-OAEP-256, as mentioned in RFC 7518 (https://datatracker.ietf.org/doc/html/rfc7518#section-4.1) and fixes Issue 1293