Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AotCompatibilityTests #2066

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix AotCompatibilityTests #2066

merged 1 commit into from
Apr 27, 2023

Conversation

eerhardt
Copy link
Contributor

  • Use Path.Combine so it works on non-Windows
  • Increase the timeout to 3 minutes, since slower machines are seeing this test take around 1 minute
  • Use the plain TreatWarningsAsErrors property

@eerhardt
Fix AotCompatibilityTests
68b49db 
- Use Path.Combine so it works on non-Windows
- Increase the timeout to 3 minutes, since slower machines are seeing this test take around 1 minute
- Use the plain TreatWarningsAsErrors property
@eerhardt
Copy link
Contributor Author

FYI @brentschmaltz

@brentschmaltz brentschmaltz merged commit bf23a03 into dev Apr 27, 2023
@eerhardt eerhardt deleted the eerhardt/FixAotTest branch April 27, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentschmaltz brentschmaltz brentschmaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerhardt @brentschmaltz