Xiao/LKG configuration cache #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciaozhang
changed the title
TimHannMSFT
reviewed
Jan 24, 2023
src/Microsoft.IdentityModel.Tokens/BaseConfigurationComparer.cs
Outdated
Show resolved
Hide resolved
TimHannMSFT
reviewed
Jan 24, 2023
src/Microsoft.IdentityModel.Tokens/BaseConfigurationComparer.cs
Outdated
Show resolved
Hide resolved
TimHannMSFT
reviewed
Jan 24, 2023
TimHannMSFT
reviewed
Jan 24, 2023
TimHannMSFT
reviewed
Jan 24, 2023
ciaozhang
changed the title
ciaozhang
force-pushed
the
Xiao/LgkConfigCache
branch
from
4cf75e3 to
32e63b8
Compare
TimHannMSFT
reviewed
Jan 27, 2023
test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTests.cs
Outdated
Show resolved
Hide resolved
TimHannMSFT
reviewed
Jan 27, 2023
test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTests.cs
Outdated
Show resolved
Hide resolved
TimHannMSFT
reviewed
Jan 28, 2023
test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTests.cs
Outdated
Show resolved
Hide resolved
TimHannMSFT
reviewed
Jan 28, 2023
test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTests.cs
Show resolved
Hide resolved
TimHannMSFT
reviewed
Jan 28, 2023
TimHannMSFT
reviewed
Jan 28, 2023
test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTests.cs
Outdated
Show resolved
Hide resolved
TimHannMSFT
reviewed
Jan 28, 2023
Not part of your change but why do we need to be so lax here? Wouldn't we always want T to be of type BaseConfiguration? Refers to: test/Microsoft.IdentityModel.TestUtils/MockConfigurationManager.cs:17 in 32e63b8. [](commit_id = 32e63b8, deletion_comment = False) |
TimHannMSFT
reviewed
Jan 28, 2023
test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTests.cs
Show resolved
Hide resolved
ciaozhang
commented
Jan 31, 2023
RojaEnnam
reviewed
Feb 1, 2023
src/Microsoft.IdentityModel.Tokens/BaseConfigurationComparer.cs
Outdated
Show resolved
Hide resolved
ciaozhang
commented
Feb 4, 2023
ciaozhang
force-pushed
the
Xiao/LgkConfigCache
branch
from
97c9727 to
90d3174
Compare
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.cs
Outdated
Show resolved
Hide resolved
ciaozhang
force-pushed
the
Xiao/LgkConfigCache
branch
from
fabc0d9 to
5b2d191
Compare
brentschmaltz
approved these changes
Mar 28, 2023
ciaozhang
force-pushed
the
Xiao/LgkConfigCache
branch
from
6d4c2ee to
9e9a05d
Compare
…ration instead of a single entry of configuration.
ciaozhang
force-pushed
the
Xiao/LgkConfigCache
branch
from
9e9a05d to
ddf2592
Compare
renovate bot
referenced
this pull request
in orso-co/Orso.Arpa.Api
Apr 7, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [System.IdentityModel.Tokens.Jwt](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet) | nuget | minor | `6.27.0` -> `6.28.1` | --- ### Release Notes <details> <summary>AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet</summary> ### [`v6.28.1`](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/6.28.1) [Compare Source](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/6.28.0...6.28.1) - Bug fix where internal cache was not instantiated [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2045](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2045) ### [`v6.28.0`](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/6.28.0) [Compare Source](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/6.27.0...6.28.0) - Enrich metadata failure message during metadata refresh interval [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2010](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2010) - Updated fix for controlling depth [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2024](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2024) - Update Wilson logs with aka.ms pointers to known wikis in [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2027](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2027) - Fix typo in documentation [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2034](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2034) - Introduce a LKG configuration cache to store each valid base configuration instead of a single entry of configuration [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2007](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2007) - Add encryption keys to base configuration [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2023](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2023) - Updated CHANGELOG link [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2026](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2026) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a LKG configuration cache to store each valid base configuration instead of a single entry of configuration.