JsonWebTokenHandler to return the JsonWebToken on validation failure #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meters.IncludeTokenOnFailedValidation is set
dannybtsai
force-pushed
the
danny/ReturnJwtOnFailure-dev
branch
from
bd4f5c7 to
624ba51
Compare
sruke
reviewed
Jan 3, 2023
src/Microsoft.IdentityModel.Tokens/TokenValidationParameters.cs
Outdated
Show resolved
Hide resolved
sruke
reviewed
Jan 3, 2023
sruke
reviewed
Jan 3, 2023
|
Consider adding documentation to PR or release notes detailing which TokenValidationParameter to set and how to retrieve the token on validation failiure. |
|
TokenValidationParameterTests and TokenValidationResultTests tests are failing. Please review the failures and update the tests. |
…meters.IncludeTokenOnFailedValidation is set
dannybtsai
force-pushed
the
danny/ReturnJwtOnFailure-dev
branch
from
f704809 to
a339a5b
Compare
sruke
approved these changes
Jan 13, 2023
build/version.props
Outdated
| @@ -1,7 +1,7 @@ | |||
| <!-- This file may be overwritten by automation. Only values allowed here are VersionPrefix and VersionSuffix. --> | |||
| <Project> | |||
| <PropertyGroup> | |||
| <VersionPrefix>0.0.1</VersionPrefix> | |||
There was a problem hiding this comment.
@dannybtsai, did you accidentally check-in this file?
buildConfiguration.xml
Outdated
| @@ -2,8 +2,8 @@ | |||
| <dotnetArchitecture>x64</dotnetArchitecture> | |||
| <nugetVersion>3.5.0-rc-1285</nugetVersion> | |||
| <runtimes>net45,net461,netstandard2.0</runtimes> | |||
| <assemblyVersion>6.25.2</assemblyVersion> | |||
| <nugetSuffix>preview</nugetSuffix> | |||
There was a problem hiding this comment.
@dannybtsai, did you accidentally check-in this file?
build.ps1
Outdated
| @@ -1,7 +1,7 @@ | |||
| param( | |||
| [string]$buildType="Debug", | |||
| [string]$dotnetDir="c:\Program Files\dotnet", | |||
| [string]$msbuildDir="C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin", | |||
There was a problem hiding this comment.
@dannybtsai, did you accidentally check-in this file?
ciaozhang
reviewed
Jan 13, 2023
| @@ -22,8 +22,8 @@ public void Publics() | |||
| TokenValidationParameters validationParameters = new TokenValidationParameters(); | |||
| Type type = typeof(TokenValidationParameters); | |||
| PropertyInfo[] properties = type.GetProperties(); | |||
| if (properties.Length != 56) | |||
There was a problem hiding this comment.
Should we define a constant instead of hard-coding it?
renovate bot
referenced
this pull request
in orso-co/Orso.Arpa.Api
Jan 24, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [System.IdentityModel.Tokens.Jwt](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet) | nuget | minor | `6.25.1` -> `6.26.0` | --- ### Release Notes <details> <summary>AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet</summary> ### [`v6.26.0`](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/6.26.0) [Compare Source](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/6.25.1...6.26.0) Servicing release Introducing a new boolean TokenValidationParameter LogTokenId. [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2002](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2002) Update System.Text.Encodings.Web [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1997](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1997) Update ValidateToken call stack fully async [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1996](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1996) JsonWebTokenHandler to return the JsonWebToken on validation failure [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1989](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1989) Update documentation of DefaultTokenLifetimeInMinutes [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1988](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1988) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDkuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEwOS4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Mar 28, 2023
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a validation fails, the JsonWebTokenHandler should return the JsonWebToken so the caller can check the claims and log details if needed.