Send additional data to metadata end point #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RojaEnnam
changed the title
| { | ||
| // remove this header if it already exists. | ||
| // we don't want to add an additional value in case when a telemetry header already exists, but to overwrite it. | ||
| request.Headers.Remove(parameter.Key); |
There was a problem hiding this comment.
Why would an existing telemetry header exist?
Can we shorten the comment to explain why we need to remove existing?
mafurman
reviewed
Aug 6, 2021
|
|
||
| if (additionalHeaders != null) | ||
| { | ||
| foreach (var parameter in additionalHeaders) |
There was a problem hiding this comment.
nit: would it make more sense to call this variable 'header' rather than 'parameter'?
There was a problem hiding this comment.
@RojaEnnam can you make this change and then we can approve.
brentschmaltz
approved these changes
Aug 11, 2021
RojaEnnam
force-pushed
the
roennam/SendAppId
branch
from
8d23443
to
20589d9
Compare
|
What's the requirement or issue that motivated this "feature"? It's not linked here, so it's curious what this is for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send additional data to metadata end point