Added a setter for the AuthenticationProtocolMessage.Script property #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoK
approved these changes
Oct 17, 2019
| @@ -148,7 +149,7 @@ public string IssuerAddress | |||
| set | |||
| { | |||
| if (value == null) | |||
| throw LogHelper.LogArgumentNullException("value"); | |||
| throw LogHelper.LogArgumentNullException(nameof(IssuerAddress)); | |||
There was a problem hiding this comment.
nice.
We should follow this pattern.
mafurman
force-pushed
the
mafurman/setScript
branch
from
7fb628e to
68782df
Compare
|
/azp run |
mafurman
force-pushed
the
mafurman/setScript
branch
from
68782df to
37ee5fd
Compare
mafurman
added a commit
that referenced
this pull request
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1263.
Also modified the setters for the other public properties on
AuthenticationProtocolMessageso that if anArgumentNullExceptionis thrown it includes the name of the property (not just "value").NOTE:
LogHelper.LogArgumentNullException()uses the following message:"IDX10000: The parameter '{0}' cannot be a 'null' or an empty object."This doesn't really make sense for the properties on this class since they can be empty strings.
Should another log message be added that's just "the parameter cannot be null"?