Fix erroneous double list allocation in JsonWebToken.Audiences (#2172)

AzureAD · Sep 7, 2023 · ff0f190 · ff0f190
1 parent 5ee9f1d
commit ff0f190
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/src/Microsoft.IdentityModel.JsonWebTokens/JsonWebToken.cs b/src/Microsoft.IdentityModel.JsonWebTokens/JsonWebToken.cs
@@ -604,19 +604,17 @@ public IEnumerable<string> Audiences
                     lock (_audiencesLock)
                     {
                         if (_audiences == null)
-
-                            _audiences = new List<string>();
-
                         if (Payload.TryGetValue(JwtRegisteredClaimNames.Aud, out JsonElement audiences))
                         {
-                            if (audiences.ValueKind == JsonValueKind.String)
-                                _audiences = new List<string> { audiences.GetString() };
-
-                            if (audiences.ValueKind == JsonValueKind.Array)
-                            {
-                                foreach (JsonElement jsonElement in audiences.EnumerateArray())
-                                    _audiences.Add(jsonElement.ToString());
-                            }
+                                if (audiences.ValueKind == JsonValueKind.String)
+                                {
+                                    _audiences = new List<string> { audiences.GetString() };
+                                }
+                                else if (audiences.ValueKind == JsonValueKind.Array)
+                                {
+                                    foreach (JsonElement jsonElement in audiences.EnumerateArray())
+                                        _audiences.Add(jsonElement.ToString());
+                                }
                         }
                     }
                 }