Update README.md #55
Merged
Update README.md #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Usha
requested changes
Aug 5, 2020
README.md
Outdated
| @@ -10,7 +10,7 @@ You can also use this Github Action to deploy your customized image into an Azur | |||
|
|
|||
| For deploying container images to Kubernetes, consider using [Kubernetes deploy](https://github.com/Azure/k8s-deploy) action. This action requires that the cluster context be set earlier in the workflow by using either the [Azure/aks-set-context](https://github.com/Azure/aks-set-context/tree/releases/v1) action or the [Azure/k8s-set-context](https://github.com/Azure/k8s-set-context/tree/releases/v1) action. | |||
|
|
|||
| The definition of this Github Action is in [action.yml](https://github.com/Azure/webapps-deploy/blob/master/action.yml). | |||
| The definition of this Github Action is in [action.yml](https://github.com/Azure/webapps-deploy/blob/master/action.yml). Currently startup-command is not supported for Windows Web Apps and for Publish Profile auth scheme. | |||
There was a problem hiding this comment.
Plz call out explicitly we support start up command for all Linux app scenarios and for the combination of Windows apps + SPN
There was a problem hiding this comment.
for windows + SPN we dont support. In general, windows apps we dont support currently.
There was a problem hiding this comment.
okk.. lets just call out what we support then 👍
N-Usha
reviewed
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37