-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoking AzureResourceFilterUtility.getAppDetails with slotname (master) #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShilpiRachna1
had a problem deploying
to
automation test
July 15, 2024 18:14 — with
GitHub Actions
Failure
ShilpiRachna1
had a problem deploying
to
automation test
July 15, 2024 18:14 — with
GitHub Actions
Failure
ShilpiRachna1
changed the title
Invoking AzureResourceFilterUtility.getAppDetails with slotname
Invoking AzureResourceFilterUtility.getAppDetails with slotname (master)
Jul 15, 2024
ShilpiRachna1
had a problem deploying
to
automation test
July 21, 2024 16:05 — with
GitHub Actions
Failure
ShilpiRachna1
had a problem deploying
to
automation test
July 21, 2024 16:05 — with
GitHub Actions
Failure
ShilpiRachna1
had a problem deploying
to
automation test
July 21, 2024 16:13 — with
GitHub Actions
Failure
ShilpiRachna1
had a problem deploying
to
automation test
July 21, 2024 16:31 — with
GitHub Actions
Failure
ShilpiRachna1
had a problem deploying
to
automation test
July 21, 2024 16:46 — with
GitHub Actions
Failure
ShilpiRachna1
had a problem deploying
to
automation test
July 21, 2024 16:55 — with
GitHub Actions
Failure
ShilpiRachna1
temporarily deployed
to
automation test
July 21, 2024 17:08 — with
GitHub Actions
Inactive
ShilpiRachna1
temporarily deployed
to
automation test
July 21, 2024 17:16 — with
GitHub Actions
Inactive
ShilpiRachna1
temporarily deployed
to
automation test
July 21, 2024 17:16 — with
GitHub Actions
Inactive
ShilpiRachna1
temporarily deployed
to
automation test
July 22, 2024 08:35 — with
GitHub Actions
Inactive
ShilpiRachna1
temporarily deployed
to
automation test
July 22, 2024 08:36 — with
GitHub Actions
Inactive
surenderssm
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
surenderssm
approved these changes
Jul 23, 2024
kumaraksh1
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes:
Updated version of package azure-actions-appservice-rest to 1.3.16 which has the support for querying slot app service.
Calling AzureResourceFilterUtility.getAppDetails with slotname
All other changes are due to npm run build
Testing
Tested by deploying to all the slots of web app https://ms.portal.azure.com/#@microsoft.onmicrosoft.com/resource/subscriptions/bef29afb-3c08-4894-ae64-43bdd8f3f447/resourceGroups/kudulitemanthantestingcoverage/providers/Microsoft.Web/sites/GHA-shilpir/deploymentSlotsV2 from the source branch.
The 2 slots in the test app are setup with basic auth and federated credentials