Remove publish profile from logs #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asranja
reviewed
Feb 18, 2020
| @@ -23,7 +23,7 @@ async function main() { | |||
|
|
|||
| // Initialize action inputs | |||
| let endpoint: IAuthorizer = !!core.getInput('publish-profile') ? null : await AuthorizerFactory.getAuthorizer(); | |||
| let actionParams: ActionParameters = ActionParameters.getActionParams(endpoint); | |||
| ActionParameters.getActionParams(endpoint); | |||
asranja
reviewed
Feb 18, 2020
| @@ -33,9 +33,9 @@ export function validateAppDetails() { | |||
|
|
|||
| if(!!actionParams.appName || (!!actionParams.slotName && actionParams.slotName !== 'production')) { | |||
There was a problem hiding this comment.
Assuming there will not be an issue with case-sensitivity here.
There was a problem hiding this comment.
This condition is to check default case, which we ourselves have set if user doesn't provide a value
asranja
reviewed
Feb 18, 2020
| let appNameMatch: boolean = !actionParams.appName || actionParams.appName === splitUsername[0]; | ||
| let slotNameMatch: boolean = actionParams.slotName === 'production' || actionParams.slotName === splitUsername[1]; | ||
| let splitUsername: string[] = creds.username.toUpperCase().substring(1).split("__"); | ||
| let appNameMatch: boolean = !actionParams.appName || actionParams.appName.toUpperCase() === splitUsername[0]; |
There was a problem hiding this comment.
It is not really required to specify type for all cases. Typescript will auto detect the type in most cases.
There was a problem hiding this comment.
It does but this is best practice. typescript by definition allows you to define types for your variables. Just trying to use that capability explicitly
asranja
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.