Kubeapp (releases/v2) #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mattchenderson
force-pushed
the
kubeapp-v2-merge
branch
from
eef68af to
468f442
Compare
mattchenderson
force-pushed
the
kubeapp-v2-merge
branch
from
468f442 to
4a35b6c
Compare
|
@AmrutaKawade , can you please review this to see if the expected changes for kubeapp are there |
| @@ -28,7 +28,8 @@ export function validateAppDetails() { | |||
|
|
|||
| if(!!actionParams.appName || (!!actionParams.slotName && actionParams.slotName.toLowerCase() !== 'production')) { | |||
| let creds: ScmCredentials = PublishProfile.getPublishProfile(actionParams.publishProfileContent).creds; | |||
| let splitUsername: string[] = creds.username.toUpperCase().substring(1).split("__"); | |||
| //for kubeapps in publishsettings file username doesn't start with $, for all other apps it starts with $ | |||
There was a problem hiding this comment.
Lib file corresponding to this file is missing.
AmrutaKawade
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison branch here was based on the
kubeappbranch.releases/v2was merged in, and conflicts resolved.Another version of this was done pulling
masterand has been opened as #141. Since there is a gap betweenmasterandreleases/v2, I was not sure which was preferable.