Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in error message #116

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Fix typo in error message #116

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3122386
Fix typo in error message
martincostello Mar 9, 2021
2009f46
Fix typo in lib
martincostello Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ActionInputValidator/ValidatorFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class ValidatorFactory {
}
}
else {
throw new Error("Valid credentails are not available. Add Azure Login action before this action or provide publish-profile input.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge latest master to your fork and run npm run build?
Please add lib folder changes as well in this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the file in lib, but running the build after an npm install generated more changes that just the typo fix, so I've not committed that as that seems beyond the scope of this typo fix as it changed various dependencies in the lock file.

throw new Error("Valid credentials are not available. Add Azure Login action before this action or provide publish-profile input.");
}
}

Expand All @@ -60,4 +60,4 @@ export class ValidatorFactory {
const appOS: string = await publishProfile.getAppOS();
actionParams.isLinux = appOS.includes(RuntimeConstants.Unix) || appOS.includes(RuntimeConstants.Unix.toLowerCase());
}
}
}