Add kind *api* to actionparameters.ts #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sanchitmehta. Can you please review this PR on adding support for 'api' kind based on whether the web app supports it? |
|
This PR is idle because it has been open for 14 days with no activity. |
|
@waeltken can you please resolve the conflicts? |
waeltken
requested review from
kaverma,
kanika1894 and
BALAGA-GAYATRI
as code owners
waeltken
temporarily deployed
to
automation test
GitHub Actions
Inactive
waeltken
temporarily deployed
to
automation test
GitHub Actions
Inactive
|
@waeltken which test case are you referring to you? |
|
@waeltken does that mean this issue is resolved for you? Or do you still need this fix? |
|
@shpraka: I think it's still a valid issue with the GitHub Action. For the problem that caused me to raise the issue, I've since moved away from the webapps-deploy action. It took to long to get fixed. |
|
@waeltken Got it. I apologize that it took very long to get this fixed. Will go ahead with merging this PR. |
shpraka
approved these changes
Dec 12, 2022
|
@shpraka There are still more "kinds" then implemented on the official Azure AppService repo: https://github.com/Azure/app-service-linux-docs/blob/master/Things_You_Should_Know/kind_property.md#app-service-resource-kind-reference |
shpraka
added a commit
that referenced
this pull request
Feb 9, 2023
* Remove publish profile from logs (#18) * Remove publish profile from logs * ignore case for app name and slot * Fix typo in action.yml * Update README.md * Update README.md * Update README.md * Remove duplicate error messages (#23) * Update README.md * Added L0 tests and yml workflow * Workflow file added * Login&sample workflow * Sampleworkflow * Cloudshell quickstart * word correction * alignment * "create webapp in Azure using app service" * Publish prof container master (#35) * Added support for container apps with publish profile * Renamed publish profile container provider * refactor * Addressed review comments * Integrated diagnostics runtime API to get appOS * updated error message * updated error messages * updated error message * updated unit tests for publish profile container * quotes fix * changes in PublishProfileContainerWebAppValidator * refactor * added package-lock.json * adding lib * Documentation updates for publish profile container (#40) * updated action.yml * Update action.yml * Update action.yml * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Fixing typo * updating webappkind enum (#44) * Moving setresourcedetails into Publish profile container (#47) * change in validation factory * Update ValidatorFactory.js * fix for runtime os * update error log * updated error log * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * publish profile for slot deployment * updated document for slot * Fix private registry credentials example config (#58) * Expand explanation of az ad sp create-for-rbac in readme (#65) * Expanding explanation of az ad sp create-for-rbac * Small edits * Add note on managing service principals * Small clarifications, especially to heading * Clarify that examples are given in the article * Update secrets link * Bump @actions/core from 1.2.1 to 1.2.6 Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.1 to 1.2.6. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) Signed-off-by: dependabot[bot] <[email protected]> * Create issue-label-bot.yaml * New appkind support (#1) * New app-kind support * handling publish profile username scenarios * renamed test folder * renamed test folder in config file * added comments * Bump lodash from 4.17.15 to 4.17.20 (#72) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update README.md (#69) Placed a link to ensure that customers loop back to the pre-requisite section before building a Web App if they have skipped over it. * Update README.md (#80) * Update README.md * Update README.md (#82) * Fixed a small syntax error in the markdown 😊 (#84) * Update README.md (#87) * Make app-name and slot-name as lower case * Temp add node_modules * audit fix * update node version * temp commit for test * revert temp commit * remove node_modules * remove unnecessary file * Addressing comment * Update issue templates * Updated Readme for webapps-deploy actions (#97) * Update README.md * Update README.md * Update README.md Co-authored-by: Usha N <[email protected]> * added logs for multicontainer support (#104) * fix for duplicate duployment issue (#111) * Fix typo in error message (#116) * Fix typo in error message Change "credentails" to "credentials". * Fix typo in lib Also fix the typo in the built code in the lib folder. * Bump y18n from 4.0.0 to 4.0.1 Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <[email protected]> * Creating a workflow to label stale issues and PRs 1. Creating a workflow to label stale issues and PRs which have been open for 14 days with no activity. 2. Also close the stale issue in 5 days. PRs are not closed automatically as of now. * Update stale.yml * Update stale.yml * Updating trigger to run on a schedule only. * Update and rename stale.yml to defaultLabels.yml (#153) * Users/balaga gayatri/defaultlabels (#158) * Update and rename stale.yml to defaultLabels.yml * Update defaultLabels.yml * Update defaultLabels.yml * Update defaultLabels.yml * updating users/amkawade/kubeapp with master (#169) (#170) * updating users/amkawade/kubeapp with master (#169) * Bump lodash from 4.17.15 to 4.17.20 (#72) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update README.md (#69) Placed a link to ensure that customers loop back to the pre-requisite section before building a Web App if they have skipped over it. * Update README.md (#80) * Update README.md * Update README.md (#82) * Fixed a small syntax error in the markdown 😊 (#84) * Update README.md (#87) * Make app-name and slot-name as lower case * Temp add node_modules * audit fix * update node version * temp commit for test * revert temp commit * remove node_modules * remove unnecessary file * Addressing comment * Update issue templates * Updated Readme for webapps-deploy actions (#97) * Update README.md * Update README.md * Update README.md Co-authored-by: Usha N <[email protected]> * added logs for multicontainer support (#104) * fix for duplicate duployment issue (#111) * Fix typo in error message (#116) * Fix typo in error message Change "credentails" to "credentials". * Fix typo in lib Also fix the typo in the built code in the lib folder. * Bump y18n from 4.0.0 to 4.0.1 Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <[email protected]> * Creating a workflow to label stale issues and PRs 1. Creating a workflow to label stale issues and PRs which have been open for 14 days with no activity. 2. Also close the stale issue in 5 days. PRs are not closed automatically as of now. * Update stale.yml * Update stale.yml * Updating trigger to run on a schedule only. * Update and rename stale.yml to defaultLabels.yml (#153) * Users/balaga gayatri/defaultlabels (#158) * Update and rename stale.yml to defaultLabels.yml * Update defaultLabels.yml * Update defaultLabels.yml * Update defaultLabels.yml Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rabeea Emad <[email protected]> Co-authored-by: Jason Freeberg <[email protected]> Co-authored-by: aksm-ms <[email protected]> Co-authored-by: Teo Voinea <[email protected]> Co-authored-by: Usha N <[email protected]> Co-authored-by: xaxle <[email protected]> Co-authored-by: Shivangi Mittal <[email protected]> Co-authored-by: 20shivangi <[email protected]> Co-authored-by: Amruta Kawade <[email protected]> Co-authored-by: Zainudeen V K <[email protected]> Co-authored-by: Usha N <[email protected]> Co-authored-by: Martin Costello <[email protected]> Co-authored-by: Kanchan Verma <[email protected]> * updating lib files * kubeapp lib files * resolving conflicts Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rabeea Emad <[email protected]> Co-authored-by: Jason Freeberg <[email protected]> Co-authored-by: aksm-ms <[email protected]> Co-authored-by: Teo Voinea <[email protected]> Co-authored-by: Usha N <[email protected]> Co-authored-by: xaxle <[email protected]> Co-authored-by: Shivangi Mittal <[email protected]> Co-authored-by: 20shivangi <[email protected]> Co-authored-by: Amruta Kawade <[email protected]> Co-authored-by: Zainudeen V K <[email protected]> Co-authored-by: Usha N <[email protected]> Co-authored-by: Martin Costello <[email protected]> Co-authored-by: Kanchan Verma <[email protected]> * Users/balaga gayatri/multi container master (#171) * added multicontainer support for linux * resolve conflicts * Update PublishProfileWebAppValidator.js * Update SpnLinuxContainerWebAppValidator.js * Update SpnWindowsContainerWebAppValidator.js * Update SpnWindowsWebAppValidator.js * Update WebAppContainerDeployment.js * Update Validations.js * Update Validations.js * Update PublishProfileWebAppContainerDeploymentProvider.js * Update PublishProfileContainerWebAppValidator.js * added necessary conditions * Adding commit message to zipDeploy payload (#127) * added commit message to zipDeploy payload * added commit message to zipDeploy payload * Added input field to the action.yml * removed node_modules * removed nodemodules * Removed node_modules from source code * Users/balaga gayatri/commit message fix (#125) * added commit message to zipDeploy payload * added commit message to zipDeploy payload * Added input field to the action.yml * removed node_modules * removed nodemodules * Removed node_modules from source code * removed taking input through action.yml * removed node_modules after testing * Users/balaga gayatri/commit message fix (#126) * added commit message to zipDeploy payload without action.yml input * Update action.yml * Removing formatting * removed whitespaces * adding node_modules * adding node_modules * debugging for head_commit message * debugging for head_commit message * debugging for head_commit message * debugging for head_commit message * Added empty commit message for non push github event * Update main.ts * Update main.ts * Users/balaga gayatri/commit message fix (#131) * Added empty commit message for non push github event * changes * added node_modules * node_modules * updated lib file * whitespace changes * Bump ws from 7.3.1 to 7.4.6 (#155) Bumps [ws](https://github.com/websockets/ws) from 7.3.1 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.3.1...7.4.6) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump hosted-git-info from 2.8.8 to 2.8.9 (#139) Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump lodash from 4.17.20 to 4.17.21 (#137) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Create CODEOWNERS (#175) * Remove windowsContainerAppNotAllowedForPublishProfile validator. (#134) * Fix typo in command name `az ad sp create-for-rbac` (#179) Everything else refers to `sp` so I assume this is just a typo. * Fix README to mention Windows container can also publish via publishing profile (#185) * Remove windowsContainerAppNotAllowedForPublishProfile validator. * Fix readme to mention Windows container can also publish using publishing profile. * Users/balaga gayatri/prchecksrepo (#163) * Create intergation-tests.yml * Create InvokeL2RepoDispatchEvent.sh * Update intergation-tests.yml * Update InvokeL2RepoDispatchEvent.sh * Update intergation-tests.yml * Delete InvokeL2RepoDispatchEvent.sh * Delete intergation-tests.yml * Create webapp_dotnet_windows_code.yml * Update webapp_dotnet_windows_code.yml * Update webapp_dotnet_windows_code.yml * Update webapp_dotnet_windows_code.yml * Update webapp_dotnet_windows_code.yml * Create webapp_python_linux_code.yml * Delete webapp_dotnet_windows_code.yml * Update webapp_python_linux_code.yml * Update webapp_python_linux_code.yml * Update webapp_python_linux_code.yml * Update webapp_python_linux_code.yml * Update webapp_python_linux_code.yml * Update webapp_python_linux_code.yml * Update webapp_python_linux_code.yml * Update webapp_python_linux_code.yml * Update webapp_python_linux_code.yml * Update and rename webapp_python_linux_code.yml to pr_check_webapp_dotnet_windows.yml * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_webapp_dotnet_windows.yml Added automation test environment * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_webapp_dotnet_windows.yml * Create pr_check_windows_container_pubprofile.yml * Update pr_check_windows_container_pubprofile.yml * Update pr_check_windows_container_pubprofile.yml * Update pr_check_windows_container_pubprofile.yml * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_windows_container_pubprofile.yml Co-authored-by: Kanika Pasrija <[email protected]> * Rename CODEOWNERS to CODEOWNER * Delete CODEOWNER * Create CODEOWNERS * Rename bug-report---feature-request.md to bug-report-feature-request.md * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_windows_container_pubprofile.yml * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_windows_container_pubprofile.yml * Update README.md * Trim commit message to not include description * Updating the workflow files with new resources (#249) * Update pr_check_windows_container_pubprofile.yml * Update pr_check_webapp_dotnet_windows.yml * Update pr_check_windows_container_pubprofile.yml (#250) * add sample github action yml for go apps on azure app services * Added node version 16 in action.yml at line no.35 (#264) This change was done for below warning message. : Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: azure/webapps-deploy@v2 * Update @actions/core (#258) * Limit the length of commit message (#271) * Limit the length of commit message * Refactor * Added comment Co-authored-by: Akshay Kumar <[email protected]> * Bump decode-uri-component from 0.2.0 to 0.2.2 (#276) Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add kind *api* to actionparameters.ts (#107) * Changed the actions-secret-parser version (#280) * Adding Resource Group As Optional Param (#283) * Adding Resource Group As Optional Param * changed the appservice web client version * Bump json5 from 2.1.3 to 2.2.3 (#281) Bumps [json5](https://github.com/json5/json5) from 2.1.3 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.1.3...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update README.md (#287) * Update README.md * Update README.md * Correcting the typo in go.yml * adding node modules change --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Sumiran Aggarwal <[email protected]> Co-authored-by: asranja <[email protected]> Co-authored-by: Ashish Ranjan <[email protected]> Co-authored-by: UshaN <[email protected]> Co-authored-by: Eavanshi Arora <[email protected]> Co-authored-by: Eavanshi Arora <[email protected]> Co-authored-by: harshitha1112 <[email protected]> Co-authored-by: aksm-ms <[email protected]> Co-authored-by: Orta Therox <[email protected]> Co-authored-by: Arjun Gupta <[email protected]> Co-authored-by: Amruta Kawade <[email protected]> Co-authored-by: Amruta Kawade <[email protected]> Co-authored-by: Gustav Tonér <[email protected]> Co-authored-by: Kraig Brockschmidt <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rabeea Emad <[email protected]> Co-authored-by: Jason Freeberg <[email protected]> Co-authored-by: Teo Voinea <[email protected]> Co-authored-by: Shivangi Mittal <[email protected]> Co-authored-by: 20shivangi <[email protected]> Co-authored-by: Zainudeen V K <[email protected]> Co-authored-by: Usha N <[email protected]> Co-authored-by: Martin Costello <[email protected]> Co-authored-by: Kanchan Verma <[email protected]> Co-authored-by: Balaga Gayatri <[email protected]> Co-authored-by: chunye <[email protected]> Co-authored-by: Thibaud Colas <[email protected]> Co-authored-by: Kanika Pasrija <[email protected]> Co-authored-by: Nathan Bierema <[email protected]> Co-authored-by: Shubham Jain <[email protected]> Co-authored-by: Shubham Jain <[email protected]> Co-authored-by: chetan-vaidya3d <[email protected]> Co-authored-by: erik-itland <[email protected]> Co-authored-by: kumaraksh1 <[email protected]> Co-authored-by: Akshay Kumar <[email protected]> Co-authored-by: Clemens Wältken <[email protected]> Co-authored-by: Surender Singh Malik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
I've tested this for a Windows API Webapp based on v2.1.5. There are probably more API kinds that need to be included. My PR does not include the updated actionparameters.js.