Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master' into releases/v2
Browse files Browse the repository at this point in the history
  • Loading branch information
shpraka committed Apr 24, 2023
2 parents 85270a1 + 83fb340 commit f9836d3
Show file tree
Hide file tree
Showing 7 changed files with 1,164 additions and 3,377 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,4 @@ jobs:
with:
app-name: ${{ env.AZURE_WEBAPP_NAME }} # Replace with your app name
publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE }}
images: ${{ env.CONTAINER_REGISTRY }}/containerwebapp/canaryreplica:latest
images: ${{ env.CONTAINER_REGISTRY }}/containerwebapp/canaryreplica:latest
2 changes: 1 addition & 1 deletion lib/Utilities/PublishProfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class PublishProfile {
throw new Error("Publish profile does not contain kudu URL");
}
this._creds.uri = `https://${this._creds.uri}`;
this._kuduService = new azure_app_kudu_service_1.Kudu(this._creds.uri, this._creds.username, this._creds.password);
this._kuduService = new azure_app_kudu_service_1.Kudu(this._creds.uri, { username: this._creds.username, password: this._creds.password });
}
catch (error) {
core.error("Failed to fetch credentials from Publish Profile. For more details on how to set publish profile credentials refer https://aka.ms/create-secrets-for-GitHub-workflows");
Expand Down
4 changes: 2 additions & 2 deletions lib/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ function main() {
isDeploymentSuccess = false;
if (error.statusCode == 403) {
core.setFailed("The deployment to your web app failed with HTTP status code 403. \
Your web app may have networking features enabled which are blocking access (such as Private Endpoints).\
For more information, please follow https://aka.ms/forbidden-deployment-error");
Your web app may have networking features enabled which are blocking access (such as Private Endpoints). \
For more information about deploying to virtual network integrated web apps, please follow https://aka.ms/gha/deploying-to-network-secured-sites");
}
else {
core.setFailed("Deployment Failed, " + error);
Expand Down
Loading

0 comments on commit f9836d3

Please sign in to comment.