Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation/Appreciation of Azure SDK packages. #61

Merged
merged 7 commits into from
Mar 15, 2021

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Mar 4, 2021

This PR intend to upgrade Azure SDK and get rid of deprecated packages. Hence inturn take care of this #14

For the future relevance I am adding extra note: the conversion is fairly bumpy transition (this advice did came handy to me when I was doing this work)

Avoid any manual type conversions: this is very important because whole azure/arm ecosystem is built differently so in case of any shortcuts, there will be internal un-bubbled errors which user will just go in loop to resolve.

There are also bunch of undocumented stuff like: For example: SubscriptionClietnts which previously part of azure-arm-resrouces is now part of azure/arm-subscription and instead of this SubscriptionClient.SubscriptionModels its just SubcriptionModels

cc: @itowlson :)

Build looks cleaner: no deprecation warnings:

Screen Shot 2021-03-04 at 5 59 58 PM

I have given some test as well and seems like things are working fine. (here are some screenshots.

Screen Shot 2021-03-04 at 2 17 36 PM

Screen Shot 2021-03-04 at 2 19 12 PM

Screen Shot 2021-03-04 at 2 18 31 PM

@Tatsinnit Tatsinnit marked this pull request as ready for review March 4, 2021 05:39
@Tatsinnit
Copy link
Member Author

Tatsinnit commented Mar 4, 2021

💡 cc: @bwateratmsft ; for comments and visibility. 🙏

@Tatsinnit Tatsinnit self-assigned this Mar 5, 2021
Copy link

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kanika1894
Copy link
Contributor

It looks good to me. Can you please share the VSIX, I'll cross check the user experience as well.

@kanika1894
Copy link
Contributor

image
None of the kubernetes assets are getting loaded. 🤔

@Tatsinnit
Copy link
Member Author

Tatsinnit commented Mar 8, 2021

Thanks for checking @kanika1894 It seems you are missing something for kubernetes extension or your VSIX is not correctly installed in VsCode. Oh and did you restarted your vscode after *.vsix install? Let’s meet up for a quick teams call? or Can you please ping me in teams? Beside GitHub emails I am not sure what’s the best channel to ping you? (Or I hope you unzipped the extension as *.VSIX and then installed it. (Long shot but just making sure)

  • Can you also please share in teams or email your vscode logs, I believe there is some local setting not right.

💡 Please Note: I will get someone at my end to vanilla test this in his/her machine as well. Pete Bomber at my end a dev who kindly tested this extension has this thing working as well and some screenshots attached as reassurance.

Here is what I did in my dev box, which had no extension and see what I have :)

image

Other dev machine test screenshots

Screen Shot 2021-03-09 at 2 05 20 PM

Screen Shot 2021-03-09 at 2 18 22 PM

@kanika1894
Copy link
Contributor

kanika1894 commented Mar 10, 2021

There was some VSCode version related issue which was causing the above problem.
Thanks to @Tatsinnit for helping me find it.
All good now ✌🏼
Also, have documented the steps of testing the integration between aks and deploy to azure extension for further releases : https://docs.google.com/document/d/1PCpsZhjV7kVfya_-HFWBmJa380Z42sPxjhtM2sln5zY/edit?usp=sharing

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@itowlson itowlson merged commit 430e893 into Azure:master Mar 15, 2021
@Tatsinnit Tatsinnit deleted the feature/deprecationpackage branch April 30, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants