-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation/Appreciation of Azure SDK packages. #61
Conversation
💡 cc: @bwateratmsft ; for comments and visibility. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
It looks good to me. Can you please share the VSIX, I'll cross check the user experience as well. |
Thanks for checking @kanika1894 It seems you are missing something for kubernetes extension or your VSIX is not correctly installed in VsCode. Oh and did you restarted your vscode after *.vsix install? Let’s meet up for a quick teams call? or Can you please ping me in teams? Beside GitHub emails I am not sure what’s the best channel to ping you? (Or I hope you unzipped the extension as *.VSIX and then installed it. (Long shot but just making sure)
💡 Please Note: Here is what I did in my dev box, which had no extension and see what I have :) Other dev machine test screenshots |
There was some VSCode version related issue which was causing the above problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
This PR intend to upgrade Azure SDK and get rid of deprecated packages. Hence inturn take care of this #14
For the future relevance I am adding extra note: the conversion is fairly bumpy transition (this advice did came handy to me when I was doing this work)
Avoid any manual type conversions: this is very important because whole
azure/arm
ecosystem is built differently so in case of any shortcuts, there will be internal un-bubbled errors which user will just go in loop to resolve.There are also bunch of undocumented stuff like: For example:
SubscriptionClietnts
which previously part ofazure-arm-resrouces
is now part ofazure/arm-subscription
and instead of thisSubscriptionClient.SubscriptionModels
its justSubcriptionModels
cc: @itowlson :)
Build looks cleaner: no deprecation warnings:
I have given some test as well and seems like things are working fine. (here are some screenshots.