Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] support generic type decorators in sdk types #966

Merged
merged 27 commits into from
Jun 26, 2024
Merged

[tcgc] support generic type decorators in sdk types #966

merged 27 commits into from
Jun 26, 2024

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Jun 6, 2024 •
edited by iscai-msft
Loading

resolve: #829, #704

current design:

  1. use whitelist configured in tspconfig.yaml to do decorators filtering, support equal/regex comparison
  2. use jsValue from typespec decorator arguments to get arguments' value
  3. only handle arguments value of typing with number/string/boolean/null/tsp enum member value/tsp literal value, other types will add a diagnostic warning

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 6, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - feature ✏️

export decorators in allow list to all sdk types

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/966/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/966/

iscai-msft
iscai-msft reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks great, thanks for your hard work on this!

packages/typespec-client-generator-core/src/internal-utils.ts Outdated Show resolved Hide resolved
packages/typespec-client-generator-core/src/internal-utils.ts Show resolved Hide resolved
packages/typespec-client-generator-core/test/package.test.ts Outdated Show resolved Hide resolved
@tadelesh tadelesh requested a review from live1206 June 7, 2024 02:36
@tadelesh
Copy link
Member Author

@iscai-msft @live1206 @m-nash could you review again?

iscai-msft
iscai-msft approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @tadelesh

@m-nash m-nash mentioned this pull request Jun 21, 2024
Merged
@tadelesh tadelesh changed the title [tcgc] initial version to support generic type decorators in sdk types [tcgc] support generic type decorators in sdk types Jun 26, 2024
@tadelesh tadelesh enabled auto-merge June 26, 2024 02:12
@tadelesh tadelesh added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 660b587 Jun 26, 2024
21 checks passed
@tadelesh tadelesh deleted the decorators_list branch June 26, 2024 03:01
@tadelesh tadelesh mentioned this pull request Jun 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 26, 2024
@tadelesh
[tcgc] change generic decorator list data structure to support duplic…
5dc55cc 
…ate decorator use case (#1082)

fix for #966
This was referenced Aug 1, 2024
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang left review comments

@jhendrixMSFT jhendrixMSFT jhendrixMSFT left review comments

@haolingdong-msft haolingdong-msft haolingdong-msft approved these changes

@m-nash m-nash m-nash approved these changes

@iscai-msft iscai-msft iscai-msft approved these changes

@lirenhe lirenhe lirenhe approved these changes

@live1206 live1206 live1206 approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a generic dictionary of decorators in TCGC for better extensibility
10 participants
@tadelesh @azure-sdk @haolingdong-msft @timotheeguerin @live1206 @lirenhe @jhendrixMSFT @ArcturusZhang @iscai-msft @m-nash