[tcgc] add generated names for constants #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
lmazuel,
m-nash,
srnagar and
joheredi
as code owners
iscai-msft
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented.
|
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/766/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/766/ |
tadelesh
approved these changes
May 6, 2024
|
i had the same idea but not finished the impl. thanks for the work. |
weidongxu-microsoft
approved these changes
May 6, 2024
pshao25
reviewed
May 6, 2024
tadelesh
pushed a commit
that referenced
this pull request
May 10, 2024
fixes #553 --------- Co-authored-by: iscai-msft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #553