Specify the fully qualified name of @OpenAPI.extension decorator in missing-x-ms-identifiers linter warning

[mjlshen]

Fixes #604 and also resolves a syntax error in the documentation for missing-x-ms-identifiers.

[timotheeguerin]

Oh nice, thanks for the fix, just need to describve the change as fix either using the comment on the PR or using pnpm change add

[timotheeguerin]

/azp run try it

[timotheeguerin]

/azp run typespec-azure - PR Try It

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-sdk]

❌ There is undocummented changes. Run chronus add to add a changeset or click here.

The following packages have changes but are not documented.

• ❌@azure-tools/typespec-azure-resource-manager

[timotheeguerin]

ah yeah looks like you'll have to update the test that were expecting the old message as well, there is also a formatting issue, make sure to run pnpm format at the end

[mjlshen]

I'm having trouble setting up my development environment locally/in VSCode. I was going through https://github.com/microsoft/typespec/blob/main/CONTRIBUTING.md

but I'm running into errors like:

❯ pnpm install      
Scope: all 12 workspace projects
/Users/mshen/git/Azure/typespec-azure/packages/e2e-tests:
 ERR_PNPM_WORKSPACE_PKG_NOT_FOUND  In packages/e2e-tests: "@typespec/compiler@workspace:~" is in the dependencies but no package named "@typespec/compiler" is present in the workspace

This error happened while installing a direct dependency of /Users/mshen/git/Azure/typespec-azure/packages/e2e-tests

Packages found in the workspace: @azure-tools/typespec-azure-monorepo, @azure-tools/e2e-tests, @azure-tools/typespec-samples, @azure-tools/typespec-autorest, @azure-tools/typespec-autorest-canonical, @azure-tools/typespec-azure-core, @azure-tools/typespec-azure-playground-website, @azure-tools/typespec-azure-portal-core, @azure-tools/typespec-azure-resource-manager, @azure-tools/typespec-client-generator-core, @azure-tools/typespec-service-csharp, @azure-tools/typespec-azure-website

❯ pnpm format      

> @azure-tools/[email protected] format /Users/mshen/git/Azure/typespec-azure
> pnpm run prettier --write


> @azure-tools/[email protected] prettier /Users/mshen/git/Azure/typespec-azure
> prettier . --config .prettierrc.json "--write"

[error] Cannot find module '/Users/mshen/git/Azure/typespec-azure/core/packages/prettier-plugin-typespec/dist/index.js' imported from /Users/mshen/.npm-global/lib/node_modules/prettier/index.mjs
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

[timotheeguerin]

ah that sounds like you haven't clone the core submodule, see this doc on how do make this work https://github.com/Azure/typespec-azure/blob/main/CONTRIBUTING.md#working-with-the-core-submodule

I have been thinking of adding a dev container setup so simplify setup for contributors, do you think that's something that would have benefited you here?

[mjlshen]

Oh that's perfect - I just didn't realize those steps were important. I'm not very familiar with JS yet, so I went down the wrong rabbithole.

A devcontainer wouldn't hurt, but the steps you linked worked as well. I mistakenly skipped to the Azure/typespec CONTRIBUTING.md searching for pnpm guidance.

[mjlshen]

Thank you @timotheeguerin for taking the time to walk me through this PR!