Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating autorest to emit response headers in lexicographic order #414

Merged
merged 12 commits into from
Apr 2, 2024
Merged

updating autorest to emit response headers in lexicographic order #414

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f18caf0
updating autorest to emit response headers in lexicographic order
allenjzhang Mar 13, 2024
ec96319
Create azhang_fixResponseHeadersOrdering-2024-2-13-6-49-41.md
allenjzhang Mar 13, 2024
9bae5b9
Updated with correct sorting configuration via schema
allenjzhang Mar 14, 2024
b67d1bd
Merge branch 'main' of https://github.com/Azure/typespec-azure into a…
allenjzhang Mar 14, 2024
c7d4f00
Merge branch 'azhang_fixResponseHeadersOrdering' of https://github.co…
allenjzhang Mar 14, 2024
ceeb6b2
Merge branch 'main' into azhang_fixResponseHeadersOrdering
allenjzhang Mar 26, 2024
0dd1e1e
Moving tests to sorting.test.ts
allenjzhang Mar 26, 2024
ff2c61b
Update packages/typespec-autorest/test/sorting.test.ts
allenjzhang Mar 26, 2024
29fa12d
Update packages/typespec-autorest/test/sorting.test.ts
allenjzhang Mar 26, 2024
f88d64c
update formating.
allenjzhang Mar 26, 2024
e711de7
Merge branch 'main' into azhang_fixResponseHeadersOrdering
timotheeguerin Apr 1, 2024
cf29c2b
Merge branch 'main' into azhang_fixResponseHeadersOrdering
timotheeguerin Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/azhang_fixResponseHeadersOrdering-2024-2-13-6-49-41.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: fix
packages:
- "@azure-tools/typespec-autorest"
---

updating autorest to emit response headers in lexicographic order
52 changes: 26 additions & 26 deletions ...core/data-plane/api-path-parameter/@azure-tools/typespec-autorest/2022-08-31/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,10 @@
"$ref": "#/definitions/Manufacturer"
},
"headers": {
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"Repeatability-Result": {
"type": "string",
"description": "Indicates whether the repeatable request was accepted or rejected.",
Expand All @@ -203,10 +207,6 @@
]
}
},
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"x-ms-client-request-id": {
"type": "string",
"format": "uuid",
Expand All @@ -220,6 +220,10 @@
"$ref": "#/definitions/Manufacturer"
},
"headers": {
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"Repeatability-Result": {
"type": "string",
"description": "Indicates whether the repeatable request was accepted or rejected.",
Expand All @@ -244,10 +248,6 @@
]
}
},
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"x-ms-client-request-id": {
"type": "string",
"format": "uuid",
Expand Down Expand Up @@ -674,6 +674,15 @@
"$ref": "#/definitions/Widget"
},
"headers": {
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"Operation-Location": {
"type": "string",
"format": "uri",
"description": "The location for monitoring the operation state."
},
"Repeatability-Result": {
"type": "string",
"description": "Indicates whether the repeatable request was accepted or rejected.",
Expand All @@ -698,19 +707,10 @@
]
}
},
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"x-ms-client-request-id": {
"type": "string",
"format": "uuid",
"description": "An opaque, globally-unique, client-generated string identifier for the request."
},
"Operation-Location": {
"type": "string",
"format": "uri",
"description": "The location for monitoring the operation state."
}
}
},
Expand All @@ -720,6 +720,15 @@
"$ref": "#/definitions/Widget"
},
"headers": {
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"Operation-Location": {
"type": "string",
"format": "uri",
"description": "The location for monitoring the operation state."
},
"Repeatability-Result": {
"type": "string",
"description": "Indicates whether the repeatable request was accepted or rejected.",
Expand All @@ -744,19 +753,10 @@
]
}
},
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"x-ms-client-request-id": {
"type": "string",
"format": "uuid",
"description": "An opaque, globally-unique, client-generated string identifier for the request."
},
"Operation-Location": {
"type": "string",
"format": "uri",
"description": "The location for monitoring the operation state."
}
}
},
Expand Down
60 changes: 30 additions & 30 deletions ...utput/azure/core/data-plane/api-path-parameter/@typespec/openapi3/openapi.2022-08-31.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,16 @@ paths:
'200':
description: The request has succeeded.
headers:
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
ETag:
required: false
description: The entity tag for the response.
schema:
type: string
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
Expand All @@ -81,16 +81,16 @@ paths:
'201':
description: The request has succeeded and a new resource has been created as a result.
headers:
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
ETag:
required: false
description: The entity tag for the response.
schema:
type: string
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
Expand Down Expand Up @@ -388,55 +388,55 @@ paths:
'200':
description: The request has succeeded.
headers:
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
ETag:
required: false
description: The entity tag for the response.
schema:
type: string
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
schema:
$ref: '#/components/schemas/Azure.Core.uuid'
Operation-Location:
required: true
description: The location for monitoring the operation state.
schema:
type: string
format: uri
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
schema:
$ref: '#/components/schemas/Azure.Core.uuid'
content:
application/json:
schema:
$ref: '#/components/schemas/Widget'
'201':
description: The request has succeeded and a new resource has been created as a result.
headers:
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
ETag:
required: false
description: The entity tag for the response.
schema:
type: string
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
schema:
$ref: '#/components/schemas/Azure.Core.uuid'
Operation-Location:
required: true
description: The location for monitoring the operation state.
schema:
type: string
format: uri
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
schema:
$ref: '#/components/schemas/Azure.Core.uuid'
content:
application/json:
schema:
Expand Down
36 changes: 18 additions & 18 deletions .../core/data-plane/custom-error-type/@azure-tools/typespec-autorest/2022-08-31/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,15 @@
"$ref": "#/definitions/Widget"
},
"headers": {
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"Operation-Location": {
"type": "string",
"format": "uri",
"description": "The location for monitoring the operation state."
},
"Repeatability-Result": {
"type": "string",
"description": "Indicates whether the repeatable request was accepted or rejected.",
Expand All @@ -206,19 +215,10 @@
]
}
},
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"x-ms-client-request-id": {
"type": "string",
"format": "uuid",
"description": "An opaque, globally-unique, client-generated string identifier for the request."
},
"Operation-Location": {
"type": "string",
"format": "uri",
"description": "The location for monitoring the operation state."
}
}
},
Expand All @@ -228,6 +228,15 @@
"$ref": "#/definitions/Widget"
},
"headers": {
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"Operation-Location": {
"type": "string",
"format": "uri",
"description": "The location for monitoring the operation state."
},
"Repeatability-Result": {
"type": "string",
"description": "Indicates whether the repeatable request was accepted or rejected.",
Expand All @@ -252,19 +261,10 @@
]
}
},
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"x-ms-client-request-id": {
"type": "string",
"format": "uuid",
"description": "An opaque, globally-unique, client-generated string identifier for the request."
},
"Operation-Location": {
"type": "string",
"format": "uri",
"description": "The location for monitoring the operation state."
}
}
},
Expand Down
40 changes: 20 additions & 20 deletions ...output/azure/core/data-plane/custom-error-type/@typespec/openapi3/openapi.2022-08-31.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,55 +57,55 @@ paths:
'200':
description: The request has succeeded.
headers:
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
ETag:
required: false
description: The entity tag for the response.
schema:
type: string
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
schema:
$ref: '#/components/schemas/Azure.Core.uuid'
Operation-Location:
required: true
description: The location for monitoring the operation state.
schema:
type: string
format: uri
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
schema:
$ref: '#/components/schemas/Azure.Core.uuid'
content:
application/json:
schema:
$ref: '#/components/schemas/Widget'
'201':
description: The request has succeeded and a new resource has been created as a result.
headers:
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
ETag:
required: false
description: The entity tag for the response.
schema:
type: string
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
schema:
$ref: '#/components/schemas/Azure.Core.uuid'
Operation-Location:
required: true
description: The location for monitoring the operation state.
schema:
type: string
format: uri
Repeatability-Result:
required: false
description: Indicates whether the repeatable request was accepted or rejected.
schema:
$ref: '#/components/schemas/RepeatabilityResult'
x-ms-client-request-id:
required: false
description: An opaque, globally-unique, client-generated string identifier for the request.
schema:
$ref: '#/components/schemas/Azure.Core.uuid'
content:
application/json:
schema:
Expand Down
Loading
Loading