Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@azure-tools/azure-http-specs] backport cadl-ranch ARM test rename #1712

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Oct 21, 2024

@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@XiaofeiCao
Copy link
Contributor Author

@sarangan12 When doing backporting, I found that without handler, mockapi will check exact body equals:
com.azure.core.management.exception.ManagementException: Status code 400, "{"message":"Body provided doesn't match expected body","expected":{"identity":{"type":"SystemAssigned"}},"actual":{"location":"eastus","tags":{"tagKey1":"tagValue1"},"properties":{},"identity":{"type":"SystemAssigned"}}}" : Body provided doesn't match expected body

Here we just want the request body to contain an expected identity property. Do you know how to achieve that?

@XiaofeiCao
Copy link
Contributor Author

XiaofeiCao commented Oct 24, 2024

@sarangan12 My bad.. Seems there're some dependency issues on my local machine. Did a fresh install and build and everything works now!

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep a few handlers, in the cases when we still need them (PATCH in ARM would be mixed behavior of normal PATCH and JSON-Merge-Patch). I assume this was what Sarangan did in cadl-ranch PR too.

(we can have follow up issue/PR to get rid of them, if we could find a way)

@XiaofeiCao
Copy link
Contributor Author

Seems we need microsoft/typespec#4846 to be synced to submodule to fix the CI.

@XiaofeiCao XiaofeiCao added this pull request to the merge queue Oct 25, 2024
Merged via the queue into Azure:main with commit 993d559 Oct 25, 2024
22 checks passed
@XiaofeiCao XiaofeiCao deleted the azure_http_specs_arm_rename branch October 25, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants