-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@azure-tools/azure-http-specs] backport cadl-ranch ARM test rename #1712
[@azure-tools/azure-http-specs] backport cadl-ranch ARM test rename #1712
Conversation
XiaofeiCao
commented
Oct 21, 2024
•
edited
Loading
edited
- origin: fix ARM scenario names cadl-ranch#714
- Fixed singleton mockapi.ts. Location is not updatable. Tested locally.
No changes needing a change description found. |
You can try these changes here
|
@sarangan12 When doing backporting, I found that without Lines 89 to 91 in 1505570
Here we just want the request body to contain an expected |
@sarangan12 My bad.. Seems there're some dependency issues on my local machine. Did a fresh install and build and everything works now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep a few handlers, in the cases when we still need them (PATCH in ARM would be mixed behavior of normal PATCH and JSON-Merge-Patch). I assume this was what Sarangan did in cadl-ranch PR too.
(we can have follow up issue/PR to get rid of them, if we could find a way)
Seems we need microsoft/typespec#4846 to be synced to submodule to fix the CI. |