Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] only expose top level client in SdkPackage #1033

Merged
merged 3 commits into from
Jun 20, 2024
Merged

[tcgc] only expose top level client in SdkPackage #1033

merged 3 commits into from
Jun 20, 2024

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Jun 18, 2024 •
edited
Loading

resolve: #1040

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 18, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - breaking ✏️

only expose top level client in SdkPackage

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1033/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1033/

qiaozha
qiaozha reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious how @client decorator would impact the listClients result and the hierachy structure between those clients?

packages/typespec-client-generator-core/test/decorators.test.ts Show resolved Hide resolved
packages/typespec-client-generator-core/test/decorators.test.ts Show resolved Hide resolved
packages/typespec-client-generator-core/test/decorators.test.ts Show resolved Hide resolved
packages/typespec-client-generator-core/test/package.test.ts Show resolved Hide resolved
packages/typespec-client-generator-core/test/package.test.ts Show resolved Hide resolved
packages/typespec-client-generator-core/src/package.ts Show resolved Hide resolved
@haolingdong-msft
Copy link
Member

Thanks for the quick action! Overall looks good to me, just leave a few minor comments.

@haolingdong-msft
Copy link
Member

PS: Please make sure that merging this pr will not close this #963. Thanks.
image

@iscai-msft iscai-msft added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit eae81f8 Jun 20, 2024
21 checks passed
@iscai-msft iscai-msft deleted the client_hierarchy branch June 20, 2024 19:34
markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Jun 26, 2024
@tadelesh @markcowl
[tcgc] only expose top level client in SdkPackage (Azure#1033)
c427e48 
resolve: Azure#1040
This was referenced Jul 29, 2024
Merged
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haolingdong-msft haolingdong-msft haolingdong-msft left review comments

@qiaozha qiaozha qiaozha left review comments

@iscai-msft iscai-msft iscai-msft approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tcgc] only expose top level client in SdkPackage
5 participants
@tadelesh @azure-sdk @haolingdong-msft @iscai-msft @qiaozha