-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tspNamespace
to SdkModelType
, SdkEnumType
, SdkEnumValueType
and SdkUnionType
#1009
Merged
ArcturusZhang
merged 8 commits into
Azure:main
from
ArcturusZhang:add-name-and-namespace-to-model-enum-and-enumvalue
Jun 18, 2024
Merged
add tspNamespace
to SdkModelType
, SdkEnumType
, SdkEnumValueType
and SdkUnionType
#1009
ArcturusZhang
merged 8 commits into
Azure:main
from
ArcturusZhang:add-name-and-namespace-to-model-enum-and-enumvalue
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar and
joheredi
as code owners
June 13, 2024 09:13
microsoft-github-policy-service
bot
added
the
lib:tcgc
Issues for @azure-tools/typespec-client-generator-core library
label
Jun 13, 2024
All changed packages have been documented.
Show changes
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1009/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1009/ |
ArcturusZhang
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
June 14, 2024 02:26
…e-to-model-enum-and-enumvalue
…e-to-model-enum-and-enumvalue
ArcturusZhang
changed the title
add namespace to
add Jun 18, 2024
SdkModelType
, SdkEnumType
, SdkEnumValueType
and SdkUnionType
tspNamespace
to SdkModelType
, SdkEnumType
, SdkEnumValueType
and SdkUnionType
tadelesh
approved these changes
Jun 18, 2024
haolingdong-msft
approved these changes
Jun 18, 2024
ArcturusZhang
deleted the
add-name-and-namespace-to-model-enum-and-enumvalue
branch
June 18, 2024 07:10
tadelesh
removed
the
lib:tcgc
Issues for @azure-tools/typespec-client-generator-core library
label
Jun 26, 2024
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Jun 26, 2024
…e` and `SdkUnionType` (Azure#1009) Fixes Azure#877
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #877