Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] add doc for new created discriminator property #872

Closed
Tracked by #1356
tadelesh opened this issue May 21, 2024 · 1 comment · Fixed by #873
Closed
Tracked by #1356

[tcgc] add doc for new created discriminator property #872

tadelesh opened this issue May 21, 2024 · 1 comment · Fixed by #873
Assignees
@tadelesh
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@tadelesh
Copy link
Member

if a discriminated base model does not define the discriminator property, tcgc will help to create one. current created property has no doc, need to add one according to autorest emitter.
@tadelesh tadelesh added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label May 21, 2024
@tadelesh tadelesh self-assigned this May 21, 2024
@tadelesh
Copy link
Member Author

issue found from Azure/autorest.go#1352

This was referenced May 21, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue May 21, 2024
@tadelesh
[tcgc] add description for created discriminator property (#873)
ce15072 
fix: #872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadelesh tadelesh

Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tcgc] add description for created discriminator property Azure/typespec-azure
1 participant
@tadelesh