Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autorest emitter wrongfully qualifies other enums as the versioning enum #838

Closed
timotheeguerin opened this issue May 15, 2024 · 0 comments · Fixed by #839
Closed

Autorest emitter wrongfully qualifies other enums as the versioning enum #838

timotheeguerin opened this issue May 15, 2024 · 0 comments · Fixed by #839
Assignees
@timotheeguerin
Labels
bug Something isn't working needs-area

Comments

@timotheeguerin
Copy link
Member

timotheeguerin commented May 15, 2024 •
edited
Loading

Playground Link

This means the enum gets omitted if it is unreferenced
@timotheeguerin timotheeguerin added the bug Something isn't working label May 15, 2024
@MaryGao MaryGao mentioned this issue May 15, 2024
Merged
@timotheeguerin timotheeguerin self-assigned this May 15, 2024
@timotheeguerin timotheeguerin mentioned this issue May 15, 2024
Merged
timotheeguerin added a commit that referenced this issue May 15, 2024
@timotheeguerin
Do not omit unreferenced non version enum when `omit-unreachable-type…
8d25298 
…s` is not set to true (#839)

fix #838

The `isVersionEnum` function was just completely wrong and just returned
true for any enum when used in a versioned spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
bug Something isn't working needs-area
Projects
None yet
Milestone
No milestone
1 participant
@timotheeguerin