Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] ManagedServiceIdentityType enum name is different between TSP and Swagger #278

Closed
XiaofeiCao opened this issue Feb 20, 2024 · 0 comments · Fixed by #400
Closed

[Bug] ManagedServiceIdentityType enum name is different between TSP and Swagger #278

XiaofeiCao opened this issue Feb 20, 2024 · 0 comments · Fixed by #400
Assignees
@allenjzhang
Labels
bug Something isn't working external:mgmt
Milestone
[2024] May

Comments

@XiaofeiCao
Copy link
Contributor

This enum is a ModelProperty type in common model ManagedServiceIdentity:

typespec-azure/packages/typespec-azure-resource-manager/lib/arm.foundations.tsp

Line 387 in ebfe639

type: ManagedIdentityType;

In swagger common types, it's named ManagedServiceIdentityType.
Though in tsp, it's named ManagedIdentityType.
@XiaofeiCao XiaofeiCao added bug Something isn't working external:mgmt MPG Impact labels Feb 20, 2024
@markcowl markcowl added this to the [2024] March milestone Feb 21, 2024
@allenjzhang allenjzhang self-assigned this Mar 5, 2024
@kazrael2119 kazrael2119 mentioned this issue Mar 11, 2024
Closed
@markcowl markcowl modified the milestones: [2024] March, [2024] April Mar 11, 2024
@allenjzhang allenjzhang mentioned this issue Mar 11, 2024
Merged
@markcowl markcowl modified the milestones: [2024] April, [2024] May Apr 6, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 15, 2024
@allenjzhang @timotheeguerin
Fixing correct name for managed identity and customer managed key, up…
376e465 
…dated enum to union (#400)

closes #278

---------

Co-authored-by: Timothee Guerin <[email protected]>
Co-authored-by: Timothee Guerin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allenjzhang allenjzhang

Labels
bug Something isn't working external:mgmt
Projects
None yet
Milestone
[2024] May
4 participants
@markcowl @allenjzhang @ArthurMa1978 @XiaofeiCao