Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Dashboard/grafana #275

Merged
merged 11 commits into from
Aug 7, 2023
Merged

Microsoft.Dashboard/grafana #275

merged 11 commits into from
Aug 7, 2023

Conversation

arindam0310018
Copy link
Contributor

@arindam0310018
Copy link
Contributor Author

Hello,
I agree to the below option under Contributor License Agreement (CLA) -

@microsoft-github-policy-service agree
(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

Many Thanks
Regards, Arindam Mitra

@arindam0310018
Copy link
Contributor Author

Hello,
I agreed to the CLA last week.
Please check my comment above.

Is there any thing pending from my side for the PR to be merged and completed ?

Please let me know

Many Thanks
Regards, Arindam Mitra

@ms-henglu ms-henglu self-requested a review April 10, 2023 02:02
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arindam0310018 ,

Thank you so much for contributing this!

This is a great example with many details. But the examples are used to demonstrate how to use azapi resources with azurerm provider, so we want to keep it simple.

Would you please remove azure pipeline file and flatten the variables into one main.tf?

Thanks!

@arindam0310018
Copy link
Contributor Author

Hello @ms-henglu
Apologies for the delayed response.
As requested, I have done below:-

  • Deleted Az devops Pipeline, Readme file, variables.tf, tfvars file.
  • Merged all into main.tf file.

Request you to review. if all found okay, may I ask to please accept the PR, merge and close.

Many Thanks
regards, Arindam Mitra

Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking time to make this PR! LGTM!

@ms-henglu ms-henglu closed this Aug 7, 2023
@ms-henglu ms-henglu reopened this Aug 7, 2023
@ms-henglu ms-henglu merged commit 0ff2c5b into Azure:main Aug 7, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants