Added new output "vnet_subnets_name_id" #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be query subnet id by subnet name this will help to refer in subsequent resource creation where it requires subnet ID, For example, need subnet ID to Application Gateway
Here is the example
locals {
frontend_subnet_id = lookup(module.vnet.vnet_subnets_name_id, subnet1)
}
The current output "vnet_subnets" it not user friendly which i feel
|
Hi @vinshetty, this change LGTM. Can you please rebase it? Thanks. |
jiaweitao001
approved these changes
Mar 4, 2022
|
Hi @jiaweitao001 , Thanks for approving the changes |
|
@jiaweitao001 @echuvyrov maybe this please could be merged already? Whole year passed :( Is this module maintained? Or it's not official azure vpc terraform module? |
|
@holms Sorry for the crazy late reply, we're going to re-active this module this week. We'll add a new CI pipeline to this module first, once the pipeline works, we'll review and merge this pr. I promise this feature will be merged in next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be query subnet id by subnet name this will help to refer in subsequent resource creation where it requires subnet ID, For example, need subnet ID to Application Gateway
Here is the example
locals {
frontend_subnet_id = lookup(module.vnet.vnet_subnets_name_id, subnet1)
}
The current output "vnet_subnets" it not user friendly which i feel
Fixes #000
Changes proposed in the pull request: