Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Databricks Default Policy Assignments to Corp MG to Match ALZ Accelerator Experience #296

Merged

Conversation

jtracey93
Copy link
Collaborator

Overview/Summary

Add Missing Databricks Default Policy Assignments to Corp MG to Match ALZ Accelerator Experience

This PR fixes/adds/changes/removes

  1. Add 3 policy assignments for databricks to corp Management Groupto match ALZ Accelerator experience
    • Deny-DataB-Pip
    • Deny-DataB-Sku
    • Deny-DataB-Vnet
  2. Fixes Missing data policies #295

Breaking Changes

None

Testing Evidence

Automated testing will suffice

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

@jtracey93 jtracey93 added the enhancement New feature or request label Mar 9, 2022
@jtracey93 jtracey93 added this to the v1.2.0 release milestone Mar 9, 2022
@jtracey93
Copy link
Collaborator Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@jtracey93
Copy link
Collaborator Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matt-FFFFFF
Copy link
Member

Wait for #287 and then rebase and merge 👍

@krowlandson
Copy link
Contributor

Wait for #287 and then rebase and merge 👍

Done and ready. Thank you

@krowlandson
Copy link
Contributor

An interesting point to note... We aren't correctly testing policy with OPA due to a memory issue whilst processing the policy objects for comparison. So we probably need to address this at some point too!

This means your unit tests should pass fine, but in truth the planned_values.json will technically be out of sync with what's actually being deployed.

@jtracey93
Copy link
Collaborator Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@matt-FFFFFF matt-FFFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jtracey93 jtracey93 merged commit 5d98edf into Azure:main Mar 9, 2022
@jtracey93 jtracey93 deleted the fix-295-missing-datab-policy-assignments branch March 9, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing data policies
3 participants