Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root_parent_id validation for Management Group ID #43

Closed
ghost opened this issue Mar 3, 2021 · 1 comment · Fixed by #44
Closed

root_parent_id validation for Management Group ID #43

ghost opened this issue Mar 3, 2021 · 1 comment · Fixed by #44
Assignees
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Mar 3, 2021

Hi.
I am trying to use an existing Management Group as root_parent_id.
This group has an id that contains an underscore, causing the validation to fail.

According to variables.tf: "The root_parent_id value must be a valid GUID, or Management Group ID."

According to Azure Portal, the id can contain: ASCII letter, digit, -, _, (, ), .
However, that is not matched by the regex in variables.tf, which only allows for letters, numbers and hyphen.

Is this an intended limitation?

/Niklas

@krowlandson krowlandson self-assigned this Mar 3, 2021
@krowlandson krowlandson added the bug Something isn't working label Mar 3, 2021
@krowlandson
Copy link
Contributor

This was by design as it matches what we were considering "supported characters" within the Enterprise-scale naming, but agree this isn't that useful so will include this update in our next release. Thank you for raising this.

krowlandson pushed a commit that referenced this issue Mar 6, 2021
- Update Unit and E2E test pipelines to use YML templates and dynamic matrix generation.
- Add custom PS module for `Enterprise Scale Library Tools` to handle automated library template updates.
- Add script and GitHub Action to enable automated library template updates from [Azure/Enterprise-Scale](https://github.com/Azure/Enterprise-Scale) repository using a CI pipeline.
- Add offline ProviderApiVersions cache in `Enterprise Scale Library Tools` to negate the need for Azure credentials.
- Update Library Templates (automated) using new CI process.
- Manual remediations to updated library templates to ensure full compatibility with Terraform (needs to be fixed at source to prevent regression).
- Update Policy Assignments and archetypes to provide parity with [WingTip reference Enterprise-Scale foundations](https://github.com/Azure/Enterprise-Scale/blob/main/docs/reference/wingtip/README.md).
- Update Resource definitions in base module to use `name` field instead of `properties.displayName` to allow setting a more "human-friendly" displayName on policies and roles.
- Fix bug where duplicate roles are created at the same scope for policy assignments with managed identity.
- Add customizable delay between deployment of different resource types to reduce deployment errors due to caching and replication in the Azure API (Improvement to help Fix #37).
- Update `root_parent_id` validation regex to include support for additional supported characters (Fix #43).
@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant