Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating existing vnet dns_server with Azure firewall leads to azurerm_virtual_network error. #1136

Open
LaurentLesle opened this issue Sep 19, 2024 · 1 comment · May be fixed by #1137
Open

Comments

@LaurentLesle
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: 1.9.5

azure provider: 3.107.0

module: 6.1.0

Description

Describe the bug

When:

  1. using the version of the module 6.1.0 and pinning the azurerm provider "~> 3.107.0"
  2. Updating a virtual network DNS to set the private IP of the Azure firewall
╷
│ Error: ID was missing the `networkSecurityGroups` element
│ 
│   with azurerm_virtual_network.some_network["test"],
│   on main.tf line 132, in resource "azurerm_virtual_network" "some_network":
│  132: resource "azurerm_virtual_network" "some_network" {
│ 
╵

This bug has been reported in the azurerm provider
hashicorp/terraform-provider-azurerm#26276 (comment)

Therefore I propose to set the minimum version of the module to 3.108.0

From terraform.tf

    azurerm = {
      source  = "hashicorp/azurerm"
      version = "~> 3.107"
      configuration_aliases = [
        azurerm.connectivity,
        azurerm.management,
      ]
    }

Steps to Reproduce

  1. step 1
  2. step 2
  3. you get it...

Screenshots

Additional context

LaurentLesle added a commit to LaurentLesle/terraform-azurerm-caf-enterprise-scale that referenced this issue Sep 19, 2024
@LaurentLesle LaurentLesle linked a pull request Sep 19, 2024 that will close this issue
5 tasks
@LaurentLesle
Copy link
Contributor Author

@matt-FFFFFF once approved it would be good if you can release a 6.2.0 to set the minimum version of Azurerm to 3.108.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant